#57 Uncaught IllegalArgumentException due to malformed unicode entity ref #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref - Added a more readable error message by means of a XmlPullParserException. - Improved validation of the numeric character reference, according to XML 1.0 spec. (https://www.w3.org/TR/REC-xml/#NT-Char)
hboutemy
requested changes
Mar 9, 2019
| @@ -2664,7 +2664,8 @@ else if ( ch == '\t' || ch == '\n' || ch == '\r' ) | |||
| entityRefName = null; | |||
| posStart = pos; | |||
| char ch = more(); | |||
| StringBuilder sb = new StringBuilder(); | |||
| StringBuilder sb16 = new StringBuilder(); | |||
| StringBuilder sb10 = new StringBuilder(); | |||
There was a problem hiding this comment.
instead of creating 2 separate string buffers, keeping sb and creating a "isHex" boolean would be a little bit more efficient and permit code sharing between the 2 cases since it's only a question of radix value, isn't it?
- Replaced two StringBuiders by one, added isHex boolean. - Added tests for valid char references. - Catched and fixed wrong parsing bug for decimal >= ✐ (supplemental) char refs.
hboutemy
approved these changes
Mar 10, 2019
|
squashed and merged 1dafbae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XmlPullParserException.
XML 1.0 spec. (https://www.w3.org/TR/REC-xml/#NT-Char)